Fix conditional joins with empty left table #9146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlowe this should unblock nightly tests. |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9146 +/- ##
===============================================
Coverage ? 10.77%
===============================================
Files ? 115
Lines ? 18722
Branches ? 0
===============================================
Hits ? 2018
Misses ? 16704
Partials ? 0 Continue to review full report at Codecov.
|
ttnghia
reviewed
Sep 1, 2021
ttnghia
reviewed
Sep 3, 2021
ttnghia
approved these changes
Sep 7, 2021
|
rerun tests |
1 similar comment
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9044 by ensuring that when the left table is empty the functions short-circuit accordingly. Where necessary (i.e. for full joins) the complementary pairs of indices are returned.