Fix joining on indexes with duplicate level names #9137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
added
bug
galipremsagar
approved these changes
Aug 27, 2021
beckernick
reviewed
Aug 27, 2021
Comment on lines
+1527
to
+1532
| # if `multiindex` has two or more levels that | ||
| # have the same name, then `multiindex.to_frame()` | ||
| # results in a DataFrame containing only one of those | ||
| # levels. Thus, set `names` to some tuple of unique values | ||
| # and then call `multiindex.to_frame(name=names)`, | ||
| # which preserves all levels of `multiindex`. |
There was a problem hiding this comment.
This is an excellent comment, as it's quite unclear from the following line of code why it's necessary
galipremsagar
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9137 +/- ##
===============================================
Coverage ? 10.83%
===============================================
Files ? 114
Lines ? 19102
Branches ? 0
===============================================
Hits ? 2070
Misses ? 17032
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, joining on indexes with duplicate level names yielded an error: