Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing child column name in dtype while reading ORC file. #9134

Merged
merged 21 commits into from
Aug 27, 2021

Conversation

rgsl888prabhu
Copy link
Contributor

Parent column was being processed first and then child column, so child column was missing the dtype information. It has been fixed.

closes #9133

@rgsl888prabhu rgsl888prabhu self-assigned this Aug 27, 2021
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner August 27, 2021 10:54
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 27, 2021
@rgsl888prabhu rgsl888prabhu added 4 - Needs cuDF (Python) Reviewer cuIO cuIO issue bug Something isn't working non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Aug 27, 2021
@rgsl888prabhu rgsl888prabhu added the 3 - Ready for Review Ready for review by team label Aug 27, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@4d8e401). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9134   +/-   ##
===============================================
  Coverage                ?   10.83%           
===============================================
  Files                   ?      114           
  Lines                   ?    19101           
  Branches                ?        0           
===============================================
  Hits                    ?     2070           
  Misses                  ?    17031           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8e401...a410119. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Aug 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e222584 into rapidsai:branch-21.10 Aug 27, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] While reading ORC file with nested struct column, dtype is missing child column name
3 participants