Apply type metadata after column is slice-copied #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
bug
isVoid
changed the title
children is slice constructed from base_childrenchildren is slice constructed from base_children
isVoid
changed the title
children is slice constructed from base_children
isVoid
added
2 - In Progress
isVoid
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9131 +/- ##
===============================================
Coverage ? 10.83%
===============================================
Files ? 114
Lines ? 19101
Branches ? 0
===============================================
Hits ? 2070
Misses ? 17031
Partials ? 0 Continue to review full report at Codecov.
|
shwina
approved these changes
Aug 27, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9121
Child column type metadata is applied after column is sliced. This resolves the issues of missing field names for nested struct columns in
__getitem__().In the process of working on this, I also ran into some issue with
StructColumn.to_arrow(). This blocks proper testing of the behavior becauseassert_eqrequires comparing the object on host.Unblocks #9086