Fix a bug: inner_join_size return zero if build table is empty #9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9128 +/- ##
===============================================
Coverage ? 10.76%
===============================================
Files ? 114
Lines ? 19086
Branches ? 0
===============================================
Hits ? 2055
Misses ? 17031
Partials ? 0 Continue to review full report at Codecov.
|
jlowe
approved these changes
Aug 26, 2021
vuule
approved these changes
Aug 26, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9092
This PR fixed a bug where
inner_join_sizewould throw an exception if the build table is empty. Corresponding unit tests are added as well.