Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add backend for percentile_lookup dispatch #9118

Merged
merged 2 commits into from
Aug 26, 2021
Merged

[REVIEW] Add backend for percentile_lookup dispatch #9118

merged 2 commits into from
Aug 26, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR adds backend for percentile_lookup dispatch in dask_cudf, related dask upstream changes were done in dask/dask#8083

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 25, 2021
@galipremsagar galipremsagar self-assigned this Aug 25, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner August 25, 2021 22:29
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 25, 2021
@jakirkham jakirkham added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 25, 2021
@jrbourbeau jrbourbeau mentioned this pull request Aug 25, 2021
Merged
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@d29c441). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2cd1d13 differs from pull request most recent head f20463f. Consider uploading reports for the commit f20463f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9118   +/-   ##
===============================================
  Coverage                ?   10.76%           
===============================================
  Files                   ?      114           
  Lines                   ?    19086           
  Branches                ?        0           
===============================================
  Hits                    ?     2055           
  Misses                  ?    17031           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29c441...f20463f. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

2 similar comments
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@pentschev pentschev mentioned this pull request Aug 26, 2021
Merged
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0ad36ff into rapidsai:branch-21.10 Aug 26, 2021
@pentschev pentschev mentioned this pull request Aug 26, 2021
Merged
This was referenced Aug 26, 2021
Merged
Merged
Merged
Merged
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @jakirkham @vyasr