Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix read_csv C++ import #9113

Closed

Conversation

viclafargue
Copy link

Some changes were recently made to the io system in #9040. It looks like the signature change of read_csv in the C++ code wasn't reported on the Cython layer. This PR should fix the problem.

@viclafargue viclafargue requested a review from a team as a code owner August 25, 2021 08:06
@viclafargue viclafargue requested review from trxcllnt and isVoid August 25, 2021 08:06
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@44bf4ba). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 27df00b differs from pull request most recent head 5baf181. Consider uploading reports for the commit 5baf181 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9113   +/-   ##
===============================================
  Coverage                ?   10.75%           
===============================================
  Files                   ?      114           
  Lines                   ?    18695           
  Branches                ?        0           
===============================================
  Hits                    ?     2010           
  Misses                  ?    16685           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bf4ba...5baf181. Read the comment docs.

@viclafargue
Copy link
Author

It seems like the problem disappeared in the following cuDF nightly distributions. The PR is apparently not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant