Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf::hash_join output size for struct joins #9107

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Fix cudf::hash_join output size for struct joins #9107

merged 4 commits into from
Aug 25, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 24, 2021

Fixes #9095.

This adds calls to flatten_nested_columns in the cudf::hash_join join output size APIs along with tests for joins on struct columns using cudf::hash_join.

@jlowe jlowe added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Aug 24, 2021
@jlowe jlowe self-assigned this Aug 24, 2021
@jlowe jlowe requested a review from a team as a code owner August 24, 2021 18:47
@robertmaynard
Copy link
Contributor

I don't think I am great person to review this since I am not familar with the purpose of hash_join. Maybe @ttnghia can review?

@jrhemstad jrhemstad requested a review from PointKernel August 24, 2021 19:44
@jlowe
Copy link
Member Author

jlowe commented Aug 24, 2021

rerun tests

ttnghia
ttnghia reviewed Aug 24, 2021
View reviewed changes
cpp/src/join/hash_join.cu Outdated Show resolved Hide resolved
cpp/src/join/hash_join.cu Outdated Show resolved Hide resolved
cpp/tests/join/join_tests.cpp Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed Aug 24, 2021
View reviewed changes
cpp/src/join/hash_join.cu Outdated Show resolved Hide resolved
ttnghia
ttnghia approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nit. Otherwise it's good.

@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@d7a05dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9107   +/-   ##
===============================================
  Coverage                ?   10.76%           
===============================================
  Files                   ?      114           
  Lines                   ?    19088           
  Branches                ?        0           
===============================================
  Hits                    ?     2054           
  Misses                  ?    17034           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a05dc...bba3c49. Read the comment docs.

PointKernel
PointKernel approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe
Copy link
Member Author

jlowe commented Aug 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f0fa255 into rapidsai:branch-21.10 Aug 25, 2021
@jlowe jlowe deleted the hash_join_structs branch August 25, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346

Assignees

@jlowe jlowe

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf::hash_join compute size fails on struct columns
4 participants
@jlowe @robertmaynard @ttnghia @PointKernel