Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support for BaseIndexer in Rolling APIs #9085

Merged
merged 9 commits into from
Aug 24, 2021
Merged

[REVIEW] Add support for BaseIndexer in Rolling APIs #9085

merged 9 commits into from
Aug 24, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 20, 2021 •
edited
Loading

Fixes: #9077

This PR adds support for BaseIndexer subclass support in Rolling APIs. This also contains a fix related to fillna - testcase added.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@abba33f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6df0850 differs from pull request most recent head 668e845. Consider uploading reports for the commit 668e845 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9085   +/-   ##
===============================================
  Coverage                ?   10.75%           
===============================================
  Files                   ?      114           
  Lines                   ?    18694           
  Branches                ?        0           
===============================================
  Hits                    ?     2010           
  Misses                  ?    16684           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abba33f...668e845. Read the comment docs.

@galipremsagar galipremsagar changed the title [WIP] Add support for BaseIndexer in Rolling APIs [REVIEW] Add support for BaseIndexer in Rolling APIs Aug 24, 2021
@galipremsagar galipremsagar marked this pull request as ready for review August 24, 2021 18:06
@galipremsagar galipremsagar requested a review from a team as a code owner August 24, 2021 18:06
@galipremsagar galipremsagar self-assigned this Aug 24, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer feature request New feature or request non-breaking Non-breaking change labels Aug 24, 2021
@galipremsagar galipremsagar requested a review from shwina August 24, 2021 18:07
shwina
shwina reviewed Aug 24, 2021
View reviewed changes
python/cudf/cudf/core/window/rolling.py
Comment on lines +218 to +219
start = as_column(start, dtype="int32")
end = as_column(end, dtype="int32")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this does a HtoD copy of a potentially large array. Thus my comment https://github.com/rapidsai/cudf/pull/9085/files#r695093462

@galipremsagar galipremsagar mentioned this pull request Aug 24, 2021
Open
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 24, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5647b53 into rapidsai:branch-21.10 Aug 24, 2021
@galipremsagar galipremsagar mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] BaseIndexer support for rolling APIs
2 participants
@galipremsagar @shwina