Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option to pass data types as strings to read_csv and read_json #9079

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 19, 2021

closes #8240

Also added a missing check for dtype count to the JSON reader and negative tests for the check.

@vuule vuule added feature request New feature or request cuIO cuIO issue breaking Breaking change labels Aug 19, 2021
@vuule vuule self-assigned this Aug 19, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@8b02ca3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2fa015e differs from pull request most recent head 47d220a. Consider uploading reports for the commit 47d220a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9079   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    18701           
  Branches                ?        0           
===============================================
  Hits                    ?     2003           
  Misses                  ?    16698           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b02ca3...47d220a. Read the comment docs.

@vuule vuule marked this pull request as ready for review August 20, 2021 02:27
@vuule vuule requested a review from a team as a code owner August 20, 2021 02:27
@vuule
Copy link
Contributor Author

vuule commented Aug 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit eb85d77 into rapidsai:branch-21.10 Aug 20, 2021
@vuule vuule deleted the fea-remove-deprecated-apis branch August 20, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] CSV and JSON readers: Pass column data types as objects instead of strings
3 participants