Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support for get_group in GroupBy #9070

Merged
merged 7 commits into from
Aug 31, 2021
Merged

[REVIEW] Add support for get_group in GroupBy #9070

merged 7 commits into from
Aug 31, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 19, 2021 •
edited
Loading

This PR adds get_group functionality to GroupBy.

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. labels Aug 19, 2021
@galipremsagar galipremsagar self-assigned this Aug 19, 2021
@galipremsagar galipremsagar changed the title [WIP] Add support for get_group in GroupBy [REVIEW] Add support for get_group in GroupBy Aug 31, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change and removed 2 - In Progress Currently a work in progress labels Aug 31, 2021
@galipremsagar galipremsagar marked this pull request as ready for review August 31, 2021 19:27
@galipremsagar galipremsagar requested a review from a team as a code owner August 31, 2021 19:27
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Aug 31, 2021
@galipremsagar galipremsagar requested a review from shwina August 31, 2021 19:28
@codecov
Copy link

codecov bot commented Aug 31, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@fdcb90a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 624f01f differs from pull request most recent head bed3e0b. Consider uploading reports for the commit bed3e0b to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9070   +/-   ##
===============================================
  Coverage                ?   10.82%           
===============================================
  Files                   ?      115           
  Lines                   ?    19125           
  Branches                ?        0           
===============================================
  Hits                    ?     2070           
  Misses                  ?    17055           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcb90a...bed3e0b. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 31, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1935a8a into rapidsai:branch-21.10 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@cwharris cwharris Awaiting requested review from cwharris

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
Pandas API Alignment and Coverage
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @shwina