-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining "support" methods from DataFrame #9068
Remove remaining "support" methods from DataFrame #9068
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9068 +/- ##
===============================================
Coverage ? 10.72%
===============================================
Files ? 114
Lines ? 18676
Branches ? 0
===============================================
Hits ? 2003
Misses ? 16673
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
This PR rewrites DataFrame's
kurtosis
andskew
to use the_reduce
method introduced in #8944, and it inlines the logic for thecount
to bypass the_apply_support_method
machinery. This allows us to remove most of that logic entirely aside from the code for row-wise reductions and scans that dispatches tocupy
.