Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining "support" methods from DataFrame #9068

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 18, 2021

This PR rewrites DataFrame's kurtosis and skew to use the _reduce method introduced in #8944, and it inlines the logic for the count to bypass the _apply_support_method machinery. This allows us to remove most of that logic entirely aside from the code for row-wise reductions and scans that dispatches to cupy.

@vyasr vyasr requested a review from a team as a code owner August 18, 2021 20:07
@vyasr vyasr self-assigned this Aug 18, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 18, 2021
@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue and removed Python Affects Python cuDF API. labels Aug 18, 2021
@vyasr vyasr added the non-breaking Non-breaking change label Aug 18, 2021
@vyasr vyasr added this to the CuDF Python Refactoring milestone Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@dfe0a03). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6171b34 differs from pull request most recent head c6aa2fb. Consider uploading reports for the commit c6aa2fb to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9068   +/-   ##
===============================================
  Coverage                ?   10.72%           
===============================================
  Files                   ?      114           
  Lines                   ?    18676           
  Branches                ?        0           
===============================================
  Hits                    ?     2003           
  Misses                  ?    16673           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe0a03...c6aa2fb. Read the comment docs.

@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Aug 18, 2021
@vyasr vyasr requested a review from charlesbluca August 19, 2021 00:06
@vyasr
Copy link
Contributor Author

vyasr commented Aug 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5869264 into rapidsai:branch-21.10 Aug 20, 2021
@vyasr vyasr deleted the refactor/df_support_methods branch January 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants