-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional format specifiers in from_timestamps #9047
Support additional format specifiers in from_timestamps #9047
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9047 +/- ##
===============================================
Coverage ? 10.82%
===============================================
Files ? 114
Lines ? 18709
Branches ? 0
===============================================
Hits ? 2026
Misses ? 16683
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
@gpucibot merge |
Reference #5991
This PR adds support for the following format specifiers in
cudf::strings::from_timestamp
This adds a new parameter to the API for the caller to pass then string names for the weekdays and months. These are only required if the
%a, %b, %A, %B
specifiers are contained in the format string.The change to
from_timestamps
is mainly a rewrite to include logic for these specifiers. Some common code required corresponding changes toto_timestamps
andis_timestamps
though these functions have not changed in this PR.