Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct namespace in cuio code examples #9037

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Aug 13, 2021

use correct namespace in cuio reader/writer code examples

@cwharris cwharris requested a review from a team as a code owner August 13, 2021 22:59
@cwharris cwharris added the doc Documentation label Aug 13, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 13, 2021
@cwharris cwharris added non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Aug 13, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 13, 2021
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check all files for similar change in this PR.

cpp/include/cudf/io/orc.hpp Show resolved Hide resolved
@cwharris cwharris requested a review from karthikeyann August 18, 2021 21:56
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@eacc24b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head da19c58 differs from pull request most recent head 98cc658. Consider uploading reports for the commit 98cc658 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9037   +/-   ##
===============================================
  Coverage                ?   10.70%           
===============================================
  Files                   ?      114           
  Lines                   ?    18708           
  Branches                ?        0           
===============================================
  Hits                    ?     2003           
  Misses                  ?    16705           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacc24b...98cc658. Read the comment docs.

Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add PR description 😃

@cwharris
Copy link
Contributor Author

cwharris commented Aug 19, 2021

@ttnghia I was under the impression the title of the PR becomes part of the commit message... There's not a lot to say here that isn't said in the title.

@cwharris
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8b02ca3 into rapidsai:branch-21.10 Aug 19, 2021
@cwharris cwharris deleted the cuio-docs-fix branch August 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants