Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rebuilding cython in build.sh #9034

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Fixes an issue where python setup.py install is called after build_ext already finishes running causing all the cython files to be recompiled one by one.

@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@2e980b8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 878cc1f differs from pull request most recent head 33c04f4. Consider uploading reports for the commit 33c04f4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9034   +/-   ##
===============================================
  Coverage                ?   10.65%           
===============================================
  Files                   ?      116           
  Lines                   ?    18676           
  Branches                ?        0           
===============================================
  Hits                    ?     1990           
  Misses                  ?    16686           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e980b8...33c04f4. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2b93331 into rapidsai:branch-21.10 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants