cudf resolve nvcc 11.0 compiler crashes during codegen #9028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with nvcc 11.0 any translation unit that uses arrow::AllocateBuffer or arrow::AllocateBitmap would cause a compiler crash durnig codegen. To avoid this issue we introduce a C++ shim between cudf/interop and arrow that does the arrow allocations for us.
robertmaynard
added
bug
ttnghia
approved these changes
Aug 12, 2021
Co-authored-by: Nghia Truong <[email protected]>
Co-authored-by: Nghia Truong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9028 +/- ##
===============================================
Coverage ? 10.65%
===============================================
Files ? 114
Lines ? 19077
Branches ? 0
===============================================
Hits ? 2033
Misses ? 17044
Partials ? 0 Continue to review full report at Codecov.
|
|
I assume the crash is fixed in more recent nvcc? If not, we should file an nvcc bug. |
harrism
approved these changes
Aug 16, 2021
You are correct. nvcc 11.1 fixed the crash |
Co-authored-by: Mark Harris <[email protected]>
Co-authored-by: Mark Harris <[email protected]>
codereport
approved these changes
Aug 17, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with nvcc 11.0 any translation unit that uses arrow::AllocateBuffer or arrow::AllocateBitmap would cause a
compiler crash during codegen.
To avoid this issue we introduce a C++ shim between cudf/interop and arrow that does the arrow allocations for us.