Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fetch correct grouping keys agg of dask groupby #9022

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 12, 2021

Fixes: #9020

This PR enables fallback to upstream dask when the groupby operation is performed by a list of Series objects.

@galipremsagar galipremsagar added bug Something isn't working 2 - In Progress Currently a work in progress 4 - Needs Dask Reviewer labels Aug 12, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 12, 2021
@galipremsagar galipremsagar changed the title [WIP] Fetch correct grouping keys [WIP] Fetch correct grouping keys agg of dask groupby Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@2c5a2ad). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8966fdd differs from pull request most recent head 7c61867. Consider uploading reports for the commit 7c61867 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9022   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    18676           
  Branches                ?        0           
===============================================
  Hits                    ?     1979           
  Misses                  ?    16697           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5a2ad...7c61867. Read the comment docs.

@galipremsagar galipremsagar marked this pull request as ready for review August 12, 2021 16:13
@galipremsagar galipremsagar requested a review from a team as a code owner August 12, 2021 16:13
@galipremsagar galipremsagar changed the title [WIP] Fetch correct grouping keys agg of dask groupby [REVIEW] Fetch correct grouping keys agg of dask groupby Aug 12, 2021
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 12, 2021
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Aug 12, 2021
@galipremsagar galipremsagar self-assigned this Aug 12, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Aug 13, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2e980b8 into rapidsai:branch-21.10 Aug 13, 2021
@vyasr vyasr added the dask Dask issue label Feb 23, 2024
@vyasr vyasr removed the dask-cudf label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support grouping by a Series in dask_cudf groupby
3 participants