Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate set_categories code #9018

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Remove duplicate set_categories code #9018

merged 1 commit into from
Aug 13, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 11, 2021

Currently the code in CategoricalAccessor.set_categories are duplicates from CategoricalColumn. It is removed in this PR.

@isVoid isVoid added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 11, 2021
@isVoid isVoid requested a review from a team as a code owner August 11, 2021 19:44
@isVoid isVoid added the improvement Improvement / enhancement to an existing function label Aug 11, 2021
@isVoid isVoid changed the title Removing duplicated set_categories code Remove duplicate set_categories code Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@f207f98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9018   +/-   ##
===============================================
  Coverage                ?   10.58%           
===============================================
  Files                   ?      116           
  Lines                   ?    19067           
  Branches                ?        0           
===============================================
  Hits                    ?     2018           
  Misses                  ?    17049           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f207f98...d734805. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 13, 2021
@galipremsagar galipremsagar added this to the CuDF Python Refactoring milestone Aug 13, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e25630a into rapidsai:branch-21.10 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
cuDF Python Refactoring
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @galipremsagar @charlesbluca