-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interleave_columns
for structs columns
#9012
Implement interleave_columns
for structs columns
#9012
Conversation
@andygrove Please test this with your test cases in Spark. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a question, does this support struct with nesting level more than 1? like Struct{Struct{Struct}}, adding a test case to cover that scenario would be helpful.
Rest looks good.
Thanks for the recommendation. Nested structs should be supported, as the interleaving process is called recursively on the children columns. I have added a test for this (2 nested levels should be enough for verifying this case). |
Rerun tests. |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9012 +/- ##
===============================================
Coverage ? 10.71%
===============================================
Files ? 114
Lines ? 18699
Branches ? 0
===============================================
Hits ? 2003
Misses ? 16696
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
This PR adds support for structs column in the
interleave_column
API. In addition, it also does a simple refactor of the existing overload functions with a new style of SFINAE implementation.Closes #8927.