Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aliases of various api.types APIs from utils.dtypes. #9011

Merged
merged 9 commits into from
Sep 15, 2021
Merged

Remove aliases of various api.types APIs from utils.dtypes. #9011

merged 9 commits into from
Sep 15, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 10, 2021 •
edited
Loading

Continuation of #8308 that moves all imports of standard dtype utilities to use cudf.api.types or cudf.core.dtypes rather than cudf.util.dtypes.

@vyasr vyasr added 1 - On Deck To be worked on next code quality Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 10, 2021
@vyasr vyasr self-assigned this Aug 10, 2021
@vyasr vyasr added the improvement Improvement / enhancement to an existing function label Aug 10, 2021
@vyasr vyasr force-pushed the refactor/pd_utils_part2 branch from 052d8d7 to 0fe2b44 Compare August 25, 2021 17:40
@vyasr
Copy link
Contributor Author

vyasr commented Aug 27, 2021

rerun tests

3 similar comments
@vyasr
Copy link
Contributor Author

vyasr commented Aug 31, 2021

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Sep 7, 2021

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Sep 8, 2021

rerun tests

@vyasr vyasr force-pushed the refactor/pd_utils_part2 branch from 10beaad to 1820693 Compare September 8, 2021 17:37
@vyasr
Copy link
Contributor Author

vyasr commented Sep 8, 2021

rerun tests

@vyasr vyasr marked this pull request as ready for review September 9, 2021 15:58
@vyasr vyasr requested a review from a team as a code owner September 9, 2021 15:58
@vyasr
Copy link
Contributor Author

vyasr commented Sep 9, 2021

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Sep 9, 2021

rerun tests

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Sep 13, 2021

rerun tests

@vyasr vyasr requested a review from a team as a code owner September 14, 2021 22:49
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@b10835c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bb66c6e differs from pull request most recent head 1ef0037. Consider uploading reports for the commit 1ef0037 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9011   +/-   ##
===============================================
  Coverage                ?   10.83%           
===============================================
  Files                   ?      115           
  Lines                   ?    18785           
  Branches                ?        0           
===============================================
  Hits                    ?     2035           
  Misses                  ?    16750           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10835c...1ef0037. Read the comment docs.

@vyasr vyasr added 3 - Ready for Review Ready for review by team breaking Breaking change and removed 1 - On Deck To be worked on next non-breaking Non-breaking change labels Sep 15, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 15, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 945b28b into rapidsai:branch-21.10 Sep 15, 2021
@vyasr vyasr mentioned this pull request Sep 17, 2021
Merged
@rjzamora rjzamora mentioned this pull request Oct 15, 2021
Closed
@vyasr vyasr deleted the refactor/pd_utils_part2 branch January 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina shwina approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @galipremsagar @shwina