Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix Dataframe indexer setitem when array is passed #9006

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #8672

This PR handles ndarray inputs in the _DataFrameLocIndexer.__setitem__

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 9, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner August 9, 2021 23:53
@galipremsagar galipremsagar self-assigned this Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@3402fec). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head efb9786 differs from pull request most recent head 8b10894. Consider uploading reports for the commit 8b10894 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9006   +/-   ##
===============================================
  Coverage                ?   10.71%           
===============================================
  Files                   ?      114           
  Lines                   ?    19097           
  Branches                ?        0           
===============================================
  Hits                    ?     2046           
  Misses                  ?    17051           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3402fec...8b10894. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 17, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit c76ec13 into rapidsai:branch-21.10 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame setitem causing data corruption for cupy array inputs
2 participants