Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java bindings for conditional join output sizes #9002

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 9, 2021

This adds Java bindings to the conditional join output size APIs added in #8928. In preparation for adding Java APIs for hash-join output sizing, it also refactors the names of the conditional join APIs to avoid overloading by adding "conditional" to the method names.

@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Aug 9, 2021
@jlowe jlowe self-assigned this Aug 9, 2021
@jlowe
Copy link
Member Author

jlowe commented Aug 9, 2021

This is in draft until the prerequisite #8928 is merged.

@jlowe jlowe marked this pull request as ready for review August 13, 2021 20:14
@jlowe jlowe requested a review from a team as a code owner August 13, 2021 20:14
@revans2
Copy link
Contributor

revans2 commented Aug 16, 2021

Looks like the dependency is merge, but the style needs to be updated.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@fb29071). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 62f758f differs from pull request most recent head 0cfc413. Consider uploading reports for the commit 0cfc413 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9002   +/-   ##
===============================================
  Coverage                ?   10.65%           
===============================================
  Files                   ?      114           
  Lines                   ?    19080           
  Branches                ?        0           
===============================================
  Hits                    ?     2033           
  Misses                  ?    17047           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb29071...0cfc413. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Aug 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit abe57f8 into rapidsai:branch-21.10 Aug 16, 2021
@jlowe jlowe deleted the jni-cond-join-output-sizes branch August 16, 2021 18:37
@vyasr vyasr added this to the Conditional Joins milestone Aug 17, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants