Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DecimalBaseColumn and move as_decimal_column #9001

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Aug 9, 2021

It is foreseeable that a few routines can be shared across Decimal32Column and Decimal64Column, thus I added a DecimalBaseColumn so that we may move shared routines to this base column. In this PR, I moved as_decimal_column so as to close #8853 .

@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 9, 2021
@isVoid isVoid changed the title Adds DecimalBaseColumn and moves as_decimal_column Add DecimalBaseColumn and move as_decimal_column Aug 9, 2021
@isVoid isVoid marked this pull request as ready for review August 11, 2021 18:05
@isVoid isVoid requested a review from a team as a code owner August 11, 2021 18:05
@isVoid isVoid requested review from shwina and galipremsagar August 11, 2021 18:05
@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 11, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@f6ce668). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9312571 differs from pull request most recent head c2a6286. Consider uploading reports for the commit c2a6286 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9001   +/-   ##
===============================================
  Coverage                ?   10.58%           
===============================================
  Files                   ?      116           
  Lines                   ?    19062           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17045           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ce668...c2a6286. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 049f08a into rapidsai:branch-21.10 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cuDF prints nothing if dataframe contains decimal32 values
2 participants