Don't unnecessarily read string offsets when doing concatenate overflow checking. #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't read the offsets to compute size.
nvdbaranec
added
libcudf
nvdbaranec
requested review from
robertmaynard and
codereport
and removed request for
a team
davidwendt
approved these changes
Aug 5, 2021
ttnghia
approved these changes
Aug 5, 2021
abellina
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
q4, q47, q57 are back to wall clock times seen in 21.06 with this change as is (with the last commit). Thanks @nvdbaranec!
|
rerun tests |
| : cudf::detail::get_value<offset_type>( | ||
| scv.offsets(), scv.offset() + b.size(), stream) - | ||
| cudf::detail::get_value<offset_type>(scv.offsets(), scv.offset(), stream)); | ||
| return a + (scv.is_empty() ? 0 |
There was a problem hiding this comment.
Not urgent but this feels ripe for refactoring to a lambda given we have dual nested ternary statements.
something like
auto computed_length = [](...)
{
....
};
return a + (scv.is_empty() ? 0 : computed_length);
raydouglass
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8960
We were always reading string offsets (device->gpu memcpy) during the concatenation overflow checking which was unnecessary when dealing with an unsliced column, resulting in a performance degradation. This fixes that.