Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cudf.dtype
function #8949cudf.dtype
function #8949Changes from 11 commits
60c7c87
5e50f52
367b743
d04a5f1
85351e9
3c9dd97
67cca8a
a10eae0
89ac918
acda2ee
64a3290
a62ab32
f79e59f
9dceb80
d0bef49
3eba47c
048629c
40736c4
550c7ba
1cfa67c
72d6304
c8925f5
26df99a
fec34d9
5fc19a9
11156f5
2a684be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this maintainable should we just lookup our
np
<->libcudf
type-map here? This was any new dtype support added will automatically be supported here bycudf.dtype
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree -- but it would be nicer if the source of truth was in a more obiously named constant. For exmaple, something like:
cudf._lib.types.SUPPORTED_NUMPY_TYPES
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to have a
cudf._lib.types.SUPPORTED_NUMPY_TYPES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a slight problem here where
<M8
is an acceptable return type here, but it's not aSUPPORTED_NUMPY_TYPE
(supported types are<M8[unit]
).