Fix concatenate empty structs #8947

sperlingxx · 2021-08-04T04:05:17Z

Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children.

Signed-off-by: sperlingxx <[email protected]>

cpp/src/structs/copying/concatenate.cu

ttnghia · 2021-08-04T04:47:14Z

In cudf PR, you don't have to add "Signed-off-by" in the PR description. Instead, add more true "description" for what the PR is doing. Also note that a description saying "Closes #....", or "Fixes #....." is not enough.

Co-authored-by: Nghia Truong <[email protected]>

ttnghia · 2021-08-05T12:47:57Z

Rerun tests.

cpp/src/structs/copying/concatenate.cu

Co-authored-by: Nghia Truong <[email protected]>

cpp/src/structs/copying/concatenate.cu

Co-authored-by: Nghia Truong <[email protected]>

sperlingxx · 2021-08-05T16:29:41Z

@ttnghia Thanks for correcting my mistakes ^ ^

cpp/src/structs/copying/concatenate.cu

codecov · 2021-08-06T05:06:31Z

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@fdf47af). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7f6fca7 differs from pull request most recent head 59015ba. Consider uploading reports for the commit 59015ba to get more accurate results

@@               Coverage Diff               @@
##             branch-21.10    #8947   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    19037           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17020           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf47af...59015ba. Read the comment docs.

sperlingxx · 2021-08-06T06:40:00Z

@gpucibot merge

Closes rapidsai#8929 Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children. Authors: - Alfred Xu (https://github.com/sperlingxx) Approvers: - Nghia Truong (https://github.com/ttnghia) - Mike Wilson (https://github.com/hyperbolic2346) URL: rapidsai#8947

fix concat struct columns with empty children

fa7b8c4

Signed-off-by: sperlingxx <[email protected]>

sperlingxx requested a review from nvdbaranec August 4, 2021 04:05

sperlingxx requested a review from a team as a code owner August 4, 2021 04:05

sperlingxx requested a review from hyperbolic2346 August 4, 2021 04:05

github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 4, 2021

sperlingxx added 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Aug 4, 2021

fix clang style

f8b1946

github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 4, 2021

ttnghia requested changes Aug 4, 2021

View reviewed changes