[REVIEW] Add deprecation warning for Series.set_mask API

[galipremsagar]

Series.set_mask is more of internal implementation detail that the end-users will not have knowledge about, hence deprecating the API.

[galipremsagar]

rerun tests

[galipremsagar]

rerun tests

[vyasr]

Two questions:

1. Do we have a general policy on removing immediately vs. deprecating? We often making breaking PRs, so not sure how we should weigh that here.
2. Do we want to indicate when we'll remove this deprecated API? Again, not sure whether we have standards for that.

[galipremsagar]

Two questions:

1. Do we have a general policy on removing immediately vs. deprecating? We often making breaking PRs, so not sure how we should weigh that here.

Nowadays, for Public APIs we usually deprecate in a release and remove in the next consecutive release(s).

2. Do we want to indicate when we'll remove this deprecated API? Again, not sure whether we have standards for that.

Don't remember ever specifying a solid version we will remove deprecated API in. There were instances we kept deprecated stuff for years 😆 I plan on removing this next immediate release along with any other bunch of deprecations(if any).

[vyasr]

Sounds good. I would like to formalize some of that a bit in the future, will put that up for discussion in the dev guide.

[galipremsagar]

@gpucibot merge

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@ec99bed). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 33ea7de differs from pull request most recent head 7031430. Consider uploading reports for the commit 7031430 to get more accurate results

@@               Coverage Diff               @@
##             branch-21.10    #8943   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    19034           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17017           
  Partials                ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec99bed...7031430. Read the comment docs.