Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply series name to result of SeriesGroupby.apply() #8939

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

charlesbluca
Copy link
Member

Closes #8899

Applies the name of SeriesGroupby.obj to the results of a SeriesGroupby.apply() operation; originally, this would be left as None.

@charlesbluca charlesbluca requested a review from a team as a code owner August 3, 2021 19:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 3, 2021
@charlesbluca charlesbluca added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@a4eabf0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f104052 differs from pull request most recent head 9c6a115. Consider uploading reports for the commit 9c6a115 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8939   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    18621           
  Branches                ?        0           
===============================================
  Hits                    ?     1972           
  Misses                  ?    16649           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4eabf0...9c6a115. Read the comment docs.

@charlesbluca
Copy link
Member Author

rerun tests

@charlesbluca charlesbluca requested a review from isVoid August 9, 2021 16:17
@charlesbluca
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e8b05de into rapidsai:branch-21.10 Aug 9, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Aug 9, 2021
Closes rapidsai#8899 

Applies the name of `SeriesGroupby.obj` to the results of a `SeriesGroupby.apply()` operation; originally, this would be left as `None`.

Authors:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

Approvers:
  - Sheilah Kirui (https://github.com/skirui-source)
  - Michael Wang (https://github.com/isVoid)

URL: rapidsai#8939
@charlesbluca charlesbluca deleted the fix-8899 branch July 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Groupby apply on a series does not retain series name
3 participants