Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdef packed_columns as cppclass instead of struct #8936

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

charlesbluca
Copy link
Member

Closes #8935

Defines packed_columns in Cython as a cppclass instead of a struct, so that it is actually destroyed when a containing PackedColumns object is no longer referenced; see cython/cython#3226.

@charlesbluca charlesbluca requested a review from a team as a code owner August 3, 2021 16:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 3, 2021
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Aug 3, 2021
@charlesbluca
Copy link
Member Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #8936 (7b57c43) into branch-21.10 (18f7c01) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 7b57c43 differs from pull request most recent head 79655f1. Consider uploading reports for the commit 79655f1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8936      +/-   ##
================================================
- Coverage         10.67%   10.61%   -0.07%     
================================================
  Files               110      116       +6     
  Lines             18271    18996     +725     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    16979     +659     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f704d6...79655f1. Read the comment docs.

@rapids-bot rapids-bot bot merged commit d20a7b2 into rapidsai:branch-21.10 Aug 3, 2021
@charlesbluca charlesbluca deleted the fix-8935 branch July 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deleting PackedColumns doesn't deallocate GPU memory
2 participants