Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting a cudf.NA into a DataFrame #8923

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Inserting a cudf.NA into a DataFrame #8923

merged 3 commits into from
Aug 2, 2021

Conversation

sarahyurick
Copy link
Contributor

Addressing #8922 - just have to check if it's a cudf.NA and set to None if necessary.

@sarahyurick sarahyurick requested a review from a team as a code owner August 2, 2021 16:50
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 2, 2021
@sarahyurick sarahyurick self-assigned this Aug 2, 2021
@sarahyurick sarahyurick added bug Something isn't working non-breaking Non-breaking change labels Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #8923 (f22014d) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head f22014d differs from pull request most recent head 80a5b15. Consider uploading reports for the commit 80a5b15 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8923      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19043     +772     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17026     +706
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba3ed5...80a5b15. Read the comment docs.

rgsl888prabhu
rgsl888prabhu approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahyurick sarahyurick added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 2, 2021
@galipremsagar galipremsagar linked an issue Aug 2, 2021 that may be closed by this pull request
[BUG] Cannot insert a cudf.NA into a DataFrame #8922
Closed
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b17024e into rapidsai:branch-21.10 Aug 2, 2021
@sarahyurick sarahyurick deleted the insert_cudfNA branch September 21, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckernick beckernick beckernick left review comments

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

Assignees

@sarahyurick sarahyurick

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot insert a cudf.NA into a DataFrame
5 participants
@sarahyurick @galipremsagar @beckernick @rgsl888prabhu @brandon-b-miller