Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support casting with Pandas dtype aliases #8920

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

sarahyurick
Copy link
Contributor

Addressing #8904. Note that it does not include the "string" alias because we already have as_string_column.

@sarahyurick sarahyurick requested a review from a team as a code owner August 2, 2021 15:09
@sarahyurick sarahyurick self-assigned this Aug 2, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 2, 2021
@sarahyurick sarahyurick added bug Something isn't working non-breaking Non-breaking change labels Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #8920 (e8bbfc4) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head e8bbfc4 differs from pull request most recent head 5e1e412. Consider uploading reports for the commit 5e1e412 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8920      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19048     +777     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17031     +711     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba3ed5...5e1e412. Read the comment docs.

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 2, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c5a575c into rapidsai:branch-21.10 Aug 2, 2021
@galipremsagar galipremsagar linked an issue Aug 2, 2021 that may be closed by this pull request
@sarahyurick sarahyurick deleted the support_aliases branch September 21, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Support casting with Pandas dtype aliases
2 participants