Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make all nvcc warnings into errors #8916

Merged
merged 6 commits into from
Nov 2, 2022
Merged

[FIX] Make all nvcc warnings into errors #8916

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd544e6
make all nvcc warnings into errors
trxcllnt Jul 30, 2021
ce58b16
Merge remote-tracking branch 'origin/branch-22.12' into fix/nvcc-Werror
vyasr Nov 1, 2022
6ab8844
Add pragmas to suppress warnings from arrow.
vyasr Nov 1, 2022
2889808
Address PR comments.
vyasr Nov 2, 2022
b0af93a
Also stop warnings on arrow/api.h.
vyasr Nov 2, 2022
0104a3d
Make warnings as errors optional.
vyasr Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/cmake/Modules/ConfigureCUDA.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ endif()
list(APPEND CUDF_CUDA_FLAGS --expt-extended-lambda --expt-relaxed-constexpr)

# set warnings as errors
list(APPEND CUDF_CUDA_FLAGS -Werror=cross-execution-space-call)
list(APPEND CUDF_CUDA_FLAGS -Werror=all-warnings)
list(APPEND CUDF_CUDA_FLAGS -Xcompiler=-Wall,-Werror,-Wno-error=deprecated-declarations)

if(DISABLE_DEPRECATION_WARNINGS)
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/io/datasource.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
#include <rmm/cuda_stream_view.hpp>

#include <arrow/buffer.h>
#pragma nv_diag_suppress 611
vyasr marked this conversation as resolved.
Show resolved Hide resolved
#include <arrow/filesystem/filesystem.h>
#include <arrow/filesystem/s3fs.h>
#pragma nv_diag_default 611
vyasr marked this conversation as resolved.
Show resolved Hide resolved
#include <arrow/io/file.h>
#include <arrow/io/interfaces.h>
#include <arrow/io/memory.h>
Expand Down
2 changes: 2 additions & 0 deletions cpp/tests/io/arrow_io_source_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
#include <cudf/io/json.hpp>
#include <cudf/io/parquet.hpp>

#pragma nv_diag_suppress 611
#include <arrow/filesystem/filesystem.h>
#pragma nv_diag_default 611
vyasr marked this conversation as resolved.
Show resolved Hide resolved
#include <arrow/io/api.h>

#include <fstream>
Expand Down