Add stream and memory-resource parameters to struct-scalar copy ctor #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8901 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19043 +772
================================================
+ Hits 1951 2017 +66
- Misses 16320 17026 +706
Continue to review full report at Codecov.
|
vyasr
approved these changes
Jul 30, 2021
karthikeyann
reviewed
Aug 2, 2021
nvdbaranec
approved these changes
Aug 2, 2021
karthikeyann
approved these changes
Aug 2, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating issue #8883 I found the
cudf::struct_scalarcopy constructor does not take a stream or memory resource parameter like the other scalar copy constructors. This PR adds the appropriate signature and implementation.Also found usage of
thrust::device_pointer_castbeing used in strings concatenate specialization to get values from an offsets column. This PR changed those to usecudf::detail::get_valueinstead to honor the current stream.