Expose days_in_month function in libcudf and add python bindings
#8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
isVoid
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8892 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19044 +773
================================================
+ Hits 1951 2017 +66
- Misses 16320 17027 +707
Continue to review full report at Codecov.
|
galipremsagar
requested changes
Jul 29, 2021
shwina
reviewed
Jul 29, 2021
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
approved these changes
Jul 29, 2021
galipremsagar
approved these changes
Jul 30, 2021
ttnghia
requested changes
Jul 30, 2021
Co-authored-by: Nghia Truong <[email protected]>
ttnghia
approved these changes
Jul 30, 2021
Co-authored-by: Nghia Truong <[email protected]>
karthikeyann
approved these changes
Aug 4, 2021
isVoid
added
5 - Ready to Merge
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Aug 9, 2021
…apidsai#8892) Closes rapidsai#8681 This PR adds `days_in_month` function in libcudf and in cudf-python. It extracts the number of days of the month that the date is in. Minor addition: - Adds examples to `is_leap_year` documentation - A previous issue with cuda10.x that precludes use of `ymd.days()` in `add_calendrical_months_functor` is now fixed because we dropped support for cuda10.x. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Nghia Truong (https://github.com/ttnghia) - Karthikeyan (https://github.com/karthikeyann) URL: rapidsai#8892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8681
This PR adds
days_in_monthfunction in libcudf and in cudf-python. It extracts the number of days of the month that the date is in.Minor addition:
is_leap_yeardocumentationymd.days()inadd_calendrical_months_functoris now fixed because we dropped support for cuda10.x.