Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java bindings for conditional join gather maps #8888

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 28, 2021

Adds Java bindings to produce gather maps using the libcudf conditional join APIs. The join condition is an AST expression that is evaluated during the join.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2021
@jlowe jlowe self-assigned this Jul 28, 2021
@jlowe jlowe requested a review from a team as a code owner July 28, 2021 19:22
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #8888 (a42099d) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head a42099d differs from pull request most recent head 437472c. Consider uploading reports for the commit 437472c to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8888      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19040     +769     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17023     +703     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8cc53...437472c. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Jul 29, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 63ac202 into rapidsai:branch-21.10 Jul 29, 2021
@vyasr vyasr added this to the Conditional Joins milestone Jul 30, 2021
@jlowe jlowe deleted the jni-cond-join branch September 10, 2021 15:47
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants