-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Series string repeat #8882
Series string repeat #8882
Conversation
Full |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8882 +/- ##
================================================
- Coverage 10.67% 10.58% -0.10%
================================================
Files 110 116 +6
Lines 18271 19050 +779
================================================
+ Hits 1951 2017 +66
- Misses 16320 17033 +713
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some copy/past typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@gpucibot merge |
Addressing rapidsai#8732. `str.repeat` function with a scalar value (e.g., `s.str.repeat(2)`) implemented - still working on working with a sequence of integers (e.g., `s.str.repeat([0,2,3])`). Still need to write tests as well. Authors: - Sarah Yurick (https://github.com/sarahyurick) Approvers: - Nghia Truong (https://github.com/ttnghia) - https://github.com/brandon-b-miller URL: rapidsai#8882
Addressing #8732.
str.repeat
function with a scalar value (e.g.,s.str.repeat(2)
) implemented - still working on working with a sequence of integers (e.g.,s.str.repeat([0,2,3])
). Still need to write tests as well.