Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series string repeat #8882

Merged
merged 9 commits into from
Aug 5, 2021

Conversation

sarahyurick
Copy link
Contributor

Addressing #8732. str.repeat function with a scalar value (e.g., s.str.repeat(2)) implemented - still working on working with a sequence of integers (e.g., s.str.repeat([0,2,3])). Still need to write tests as well.

@sarahyurick sarahyurick requested a review from a team as a code owner July 28, 2021 16:42
@sarahyurick sarahyurick marked this pull request as draft July 28, 2021 16:43
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 28, 2021
@sarahyurick sarahyurick self-assigned this Jul 28, 2021
@sarahyurick sarahyurick added Cython feature request New feature or request non-breaking Non-breaking change labels Jul 28, 2021
@sarahyurick
Copy link
Contributor Author

Full str.repeat functionality implemented - s.str.repeat(2) and s.str.repeat([0,2,3]). Still need to edit for style/comments and add tests.

@sarahyurick sarahyurick changed the title [WIP] Series string repeat Series string repeat Jul 29, 2021
@sarahyurick sarahyurick marked this pull request as ready for review July 29, 2021 02:33
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8882 (d611a00) into branch-21.10 (18f7c01) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head d611a00 differs from pull request most recent head 37ceaf2. Consider uploading reports for the commit 37ceaf2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8882      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.10%     
================================================
  Files               110      116       +6     
  Lines             18271    19050     +779     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17033     +713     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7032f47...37ceaf2. Read the comment docs.

Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some copy/past typo

python/cudf/cudf/_lib/cpp/strings/repeat.pxd Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/strings/repeat.pyx Outdated Show resolved Hide resolved
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sarahyurick sarahyurick added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 5, 2021
@beckernick
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e11b054 into rapidsai:branch-21.10 Aug 5, 2021
shwina pushed a commit to shwina/cudf that referenced this pull request Aug 9, 2021
Addressing rapidsai#8732. `str.repeat` function with a scalar value (e.g., `s.str.repeat(2)`) implemented - still working on working with a sequence of integers (e.g., `s.str.repeat([0,2,3])`). Still need to write tests as well.

Authors:
  - Sarah Yurick (https://github.com/sarahyurick)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - https://github.com/brandon-b-miller

URL: rapidsai#8882
@sarahyurick sarahyurick deleted the series_string_repeat branch September 21, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants