Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove max version pin for dask & distributed on development branch #8881

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[REVIEW] Remove max version pin for dask & distributed on development branch #8881

merged 1 commit into from
Jul 28, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR will remove max version pinning for dask & distributed for development purposes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 28, 2021
@galipremsagar galipremsagar self-assigned this Jul 28, 2021
@galipremsagar galipremsagar requested review from a team as code owners July 28, 2021 15:31
@galipremsagar galipremsagar requested review from vyasr and shwina July 28, 2021 15:31
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Jul 28, 2021
This was referenced Jul 28, 2021
Merged
Merged
Merged
vyasr
vyasr reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is the net change between this and #8859 just to make sure that __cuda_array_interface__ tests don't fail on older dask versions?

@jakirkham
Copy link
Member

We are just pinning the Dask + Distributed versions in the release. So new versions of Dask + Distributed don't accidentally break past releases

rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jul 28, 2021
@galipremsagar
Remove max version pin for dask & distributed on development branch (#…
78eca24 
…303)

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: #303
@vyasr vyasr self-requested a review July 28, 2021 17:39
vyasr
vyasr approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks. LGTM

@vyasr
Copy link
Contributor

vyasr commented Jul 28, 2021

Actually quick follow up, do we need to remove the pin that was added in that cuda array interface test, then?

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Jul 28, 2021 •
edited
Loading

Actually quick follow up, do we need to remove the pin that was added in that cuda array interface test, then?

is this the pytorch one? If yes, then no. That's needed as we don't test in CI with pytorch, but a very old version of torch is being shipped in containers somehow.

@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #8881 (88224fd) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 88224fd differs from pull request most recent head a9d03e0. Consider uploading reports for the commit a9d03e0 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8881      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19037     +766     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17020     +700
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/string.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <ø> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/core/frame.py 0.00% <ø> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0078bf6...a9d03e0. Read the comment docs.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c241177 into rapidsai:branch-21.10 Jul 28, 2021
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jul 28, 2021
@galipremsagar
Remove max version pin for dask & distributed on development bran…
96ef38c 
…ch (#4118)

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: #4118
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Jul 28, 2021
@galipremsagar
Remove max version pin for dask & distributed on development bran…
9dc4c23 
…ch (#693)

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: #693
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Remove max version pin for dask & distributed on development bran…
3932dd3 
…ch (rapidsai#4118)

This PR will remove max version pinning for dask & distributed for development purposes.

ref: rapidsai/cudf#8881

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: rapidsai#4118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jakirkham jakirkham jakirkham approved these changes

@vyasr vyasr vyasr approved these changes

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @jakirkham @vyasr @ajschmidt8