-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace auto with auto& ref for cast<&> #8866
Conversation
@davidwendt There is a comment mentioning this issue. cudf/cpp/include/cudf/detail/indexalator.cuh Line 430 in 8aaf8e6
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Ran all libcudf tests with The following tests FAILED: With this PR, still Created a new issue #8883 to track this. |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8866 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19037 +766
================================================
+ Hits 1951 2017 +66
- Misses 16320 17020 +700
Continue to review full report at Codecov.
|
@gpucibot merge |
While debugging a 'scalar out of bounds memory issue' in compiled binary ops, found that
auto
is used instead ofauto&
fordynamic/static_cast<&>
.Using
auto
, causes to create a copy. (calls copy constructor).But the intention of
cast<&>
is to create a ref variable.This PR addresses several use cases in libcudf code of
auto
fordynamic/static_cast<&>
.