-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI for extract_quarter, add_calendrical_months, and is_leap_year #8863
Add JNI for extract_quarter, add_calendrical_months, and is_leap_year #8863
Conversation
This is not really a high priority for Spark. We already support quarter of the year by getting the month and doing a bit of math with it. This should hopefully speed that up, but we have not seen it as slow in any actual queries.
Spark has no SQL API for leap year detection so that is not going to help much yet. I just thought it would be good to keep the APIs up to date. |
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8863 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19037 +766
================================================
+ Hits 1951 2017 +66
- Misses 16320 17020 +700
Continue to review full report at Codecov.
|
@gpucibot merge |
A number of new APIs have been added to cudf c++ date time processing. This wraps them with corresponding java APIs and adds a few tests.