Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add min pytorch version to importorskip in pytest #8851

Merged
merged 1 commit into from
Jul 26, 2021
Merged

[REVIEW] Add min pytorch version to importorskip in pytest #8851

merged 1 commit into from
Jul 26, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR adds minimum pytorch version in importorskip which is failing currently in CI for pytorch 1.0.

@galipremsagar galipremsagar requested a review from a team as a code owner July 26, 2021 16:42
@galipremsagar galipremsagar requested review from shwina and isVoid July 26, 2021 16:42
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 26, 2021
@galipremsagar galipremsagar self-assigned this Jul 26, 2021
@galipremsagar galipremsagar added 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed tech debt labels Jul 26, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #8851 (4e0f246) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 4e0f246 differs from pull request most recent head 14e7c1f. Consider uploading reports for the commit 14e7c1f to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8851      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19035     +764     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17018     +698
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f46f0...14e7c1f. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fdc6240 into rapidsai:branch-21.10 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@shwina shwina shwina approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @shwina @isVoid