Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java bindings for regex replace #8847

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 23, 2021

This adds Java bindings for cudf::strings::replace_re.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 23, 2021
@jlowe jlowe self-assigned this Jul 23, 2021
@jlowe jlowe requested a review from a team as a code owner July 23, 2021 22:26
@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #8847 (6f9c793) into branch-21.10 (18f7c01) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 6f9c793 differs from pull request most recent head fcddd33. Consider uploading reports for the commit fcddd33 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8847      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.09%     
================================================
  Files               110      116       +6     
  Lines             18271    19032     +761     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17015     +695     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f46f0...fcddd33. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Jul 26, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Jul 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d7ba345 into rapidsai:branch-21.10 Jul 27, 2021
@jlowe jlowe deleted the jni-string-regex-replace branch September 10, 2021 15:47
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants