Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series datetime is_month_start #8844

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Series datetime is_month_start #8844

merged 6 commits into from
Jul 28, 2021

Conversation

sarahyurick
Copy link
Contributor

Addressing feature request #8678. is_month_start returns a series indicating whether each date is the first day of the month.

@sarahyurick sarahyurick requested a review from a team as a code owner July 23, 2021 19:07
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 23, 2021
@rgsl888prabhu rgsl888prabhu added 4 - Needs cuDF (Python) Reviewer feature request New feature or request non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels Jul 23, 2021
rgsl888prabhu
rgsl888prabhu reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@rgsl888prabhu rgsl888prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good, just a question.

python/cudf/cudf/tests/test_datetime.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar linked an issue Jul 23, 2021 that may be closed by this pull request
[FEA] Series datetime is_month_start #8678
Closed
@codecov
Copy link

codecov bot commented Jul 23, 2021 •
edited
Loading

Codecov Report

Merging #8844 (9088ead) into branch-21.10 (18f7c01) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head 9088ead differs from pull request most recent head 2b252d3. Consider uploading reports for the commit 2b252d3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8844      +/-   ##
================================================
- Coverage         10.67%   10.58%   -0.10%     
================================================
  Files               110      116       +6     
  Lines             18271    18652     +381     
================================================
+ Hits               1951     1974      +23     
- Misses            16320    16678     +358
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc6240...2b252d3. Read the comment docs.

brandon-b-miller
brandon-b-miller reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment otherwise lgtm.

@sarahyurick sarahyurick self-assigned this Jul 27, 2021
@sarahyurick sarahyurick added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 27, 2021
@beckernick
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0078bf6 into rapidsai:branch-21.10 Jul 28, 2021
@sarahyurick sarahyurick deleted the is_month_start branch September 21, 2022 23:42
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

Assignees

@sarahyurick sarahyurick

Labels
4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Series datetime is_month_start
5 participants
@sarahyurick @beckernick @rgsl888prabhu @brandon-b-miller @vyasr