Re-enable JSON tests #8843
Merged
Re-enable JSON tests #8843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
hyperbolic2346
approved these changes
Jul 24, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8843 +/- ##
================================================
- Coverage 10.67% 10.58% -0.10%
================================================
Files 110 116 +6
Lines 18271 18650 +379
================================================
+ Hits 1951 1974 +23
- Misses 16320 16676 +356
Continue to review full report at Codecov.
|
jdye64
approved these changes
Jul 24, 2021
|
rerun tests |
cwharris
approved these changes
Jul 26, 2021
harrism
approved these changes
Jul 26, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
… of `data_type` objects (#8856) Goal of the PR is to enable CSV to read columns as decimal, and to replace the string-based `dtype` part of the API. `data_type` based API is needed because we need to specify scale for decimal columns, and doing this via a string that describes the type is 💩 Changes in the PR: - Added overloads to `dtype` related getters/setters to also take a vector or a map of `data_type` objects. In case of CSV, vector of `data_type`s was already supported. Reworked the implementation to support different use cases that the "dtype-as-string" code path supports. - Fixed naming of compression option setter. - Added `parse_dates` option to make up for the special strings that CSV supported to denote that a column needs to be parsed as hexadecimal (the option to pass strings is to be removed). - Changed naming of `infer_date` option to `parse_dates`. - Updated all CSV and JSON tests to use the new APIs. Breaking because API to specify date columns has been renamed to match the new `parse_hex` API; renamed from `infer_date` to `parse_dates` Depends on #8843 Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu) - AJ Schmidt (https://github.com/ajschmidt8) - Elias Stehle (https://github.com/elstehle) URL: #8856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8403 disabled a large portion of JSON tests.
This PR reverts the accidental change in that PR.