Remove make strings children with null mask #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8830 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19037 +766
================================================
+ Hits 1951 2017 +66
- Misses 16320 17020 +700
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
robertmaynard
approved these changes
Jul 28, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8580
The
cudf::strings::detail::make_strings_children_with_null_maskutility was created temporarily to help build the output column validities bitmask forjoin_lists_elements(for strings) andlists::interleave_columns(for strings). But it used a temporaryint8_tdevice vector to hold single-bit values. It would then convert theint8column into a bitmask with a kernel call. This PR removes the utility in favor of executing a kernel using thecudf::detail::valid_ifutility to build the bitmask directly without requiring a temporary buffer. Removing the temporary buffer from thejoin_list_elementsstrings API was not difficult. The temporary buffer is still used in thelists::interleave_columnsfor now.A follow on PR should change this to utilize the output bitmask and directly set the bits rather than using a temporary
int8buffer that gets converted to a bitmask. This approach could also be used in thejoin_lists_elementto ultimately avoid thevalid_ifcall.Removing this utility simplifies the code a bit and should speed up compiling any source file that includes
cudf/strings/detail/utilities.cuh(~160 files right now).