Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMake vars for python/parquet support in libarrow builds #8808

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 21, 2021

#8670 added support for Python/Parquet support in CPM builds of libarrow. This PR fixes finding arrow in non-CPM builds.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vyasr vyasr requested a review from a team as a code owner July 21, 2021 01:42
@vyasr vyasr self-assigned this Jul 21, 2021
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jul 21, 2021
@vyasr
Copy link
Contributor Author

vyasr commented Jul 21, 2021

Thanks to @trxcllnt for helping me pinpoint the underlying source of the issue. I believe that he had some ideas for CI tests that we should add to catch problems like this in the future.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@b490a32). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8808   +/-   ##
===============================================
  Coverage                ?   10.49%           
===============================================
  Files                   ?      116           
  Lines                   ?    18988           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16995           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b490a32...874c94b. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Jul 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cda2592 into rapidsai:branch-21.08 Jul 21, 2021
@vyasr vyasr deleted the fix/cmake_arrow_config branch January 14, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants