Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup (unused headers / commented code removals) #8799

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Small cleanup (unused headers / commented code removals) #8799

merged 5 commits into from
Jul 23, 2021

Conversation

codereport
Copy link
Contributor

A couple small code cleanups I came across while working on draft PR.

@codereport codereport added 3 - Ready for Review Ready for review by team code quality improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 20, 2021
@codereport codereport self-assigned this Jul 20, 2021
@codereport codereport requested a review from a team as a code owner July 20, 2021 17:57
@codereport codereport requested review from devavret and davidwendt and removed request for a team July 20, 2021 17:57
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 20, 2021
devavret
devavret reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@devavret devavret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too small for a standalone PR IMO. But even so, because PR titles go into changelog, please expand the title.

@codereport codereport changed the title Small cleanup Small cleanup (code removals) Jul 20, 2021
@codereport
Copy link
Contributor Author

Too small for a standalone PR IMO. But even so, because PR titles go into changelog, please expand the title.

We have done these PRs before:

- PR #6083 Small cleanup
- PR #5514 `convert_datetime.cu` Small Cleanup
- PR #3261 Small cleanup: remove `== true`
- PR #3492 Small cleanup (remove std::abs) and comment

and personally I don't think extra info in the title really adds much value. Usually users of libcudf care about bug fixes or features, not no-op code cleanup.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 20, 2021
@codereport
Copy link
Contributor Author

rerun tests

@harrism harrism changed the title Small cleanup (code removals) Small cleanup (unused headers / commented code removals) Jul 20, 2021
@harrism
Copy link
Member

harrism commented Jul 20, 2021

personally I don't think extra info in the title really adds much value.

I personally do. I edited the title. It's still short but explicitly covers everything you changed.

@harrism
Copy link
Member

harrism commented Jul 20, 2021

rerun tests

@codereport
Copy link
Contributor Author

rerun tests

@ttnghia
Copy link
Contributor

ttnghia commented Jul 21, 2021 •
edited
Loading

Style check failed, guys!
It seems that the style check failed not because of style.

Rerun tests.

@ttnghia
Copy link
Contributor

ttnghia commented Jul 21, 2021

Rerun tests.

@codereport
Copy link
Contributor Author

Style check failed, guys!
It seems that the style check failed not because of style.

Rerun tests.

Yea, @dillon-cullinan mentioned on Slack that 21.10 CI isn't work yet.

@ttnghia
Copy link
Contributor

ttnghia commented Jul 22, 2021

Rerun tests.

@codereport
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #8799 (82d4a3d) into branch-21.10 (18f7c01) will decrease coverage by 0.07%.
The diff coverage is 6.83%.

❗ Current head 82d4a3d differs from pull request most recent head d155bce. Consider uploading reports for the commit d155bce to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #8799      +/-   ##
================================================
- Coverage         10.67%   10.59%   -0.08%     
================================================
  Files               110      116       +6     
  Lines             18271    19030     +759     
================================================
+ Hits               1951     2017      +66     
- Misses            16320    17013     +693
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/lists.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b45fc...d155bce. Read the comment docs.

@codereport
Copy link
Contributor Author

@gpucibot merge

2 similar comments
@ttnghia
Copy link
Contributor

ttnghia commented Jul 23, 2021

@gpucibot merge

@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cd75224 into rapidsai:branch-21.10 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@mythrocks mythrocks mythrocks approved these changes

@devavret devavret devavret approved these changes

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codereport @harrism @ttnghia @ajschmidt8 @devavret @mythrocks @karthikeyann @davidwendt