Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort error in utils.pyx #8771

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

charlesbluca
Copy link
Member

Not sure if it was the timing of the gpuCI isort bump relative to the updated pre-commit hooks here, but #8749 introduced a sorting error in utils.pyx that wasn't caught by gpuCI at the time of merging.

@charlesbluca charlesbluca requested a review from a team as a code owner July 19, 2021 16:38
@charlesbluca charlesbluca requested review from shwina and isVoid July 19, 2021 16:38
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 19, 2021
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jul 19, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 19, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@b011299). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8f03bd7 differs from pull request most recent head d95081c. Consider uploading reports for the commit d95081c to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8771   +/-   ##
===============================================
  Coverage                ?   10.53%           
===============================================
  Files                   ?      116           
  Lines                   ?    18913           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16920           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b011299...d95081c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 2a8d202 into rapidsai:branch-21.08 Jul 19, 2021
@charlesbluca charlesbluca deleted the fix-utils-syntax branch August 3, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants