-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Change cudf docs theme to pydata theme #8746
[REVIEW] Change cudf docs theme to pydata theme #8746
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8746 +/- ##
===============================================
Coverage ? 10.60%
===============================================
Files ? 116
Lines ? 19005
Branches ? 0
===============================================
Hits ? 2015
Misses ? 16990
Partials ? 0 Continue to review full report at Codecov.
|
Thanks @galipremsagar ! And thank you @kkraus14 and @isVoid for the reviews. With the new theme and multiple pages we may want to consider restructuring a bit more. For example, the |
@gpucibot merge |
Think this is still blocked by rapidsai/integration#336 and an ops approval |
just waiting for the changes in rapidsai/integration#336 to be published and then this can be approved and merged. |
GitHub is having issues which is probably why this didn't merge. Let's try another merge comment. If not, we'll wait a bit until their problems are resolved. |
@gpucibot merge |
had some doc build issues. this should fix it. i tested it locally: rapidsai/integration#338 |
new docs are live: https://docs.rapids.ai/api/cudf/nightly/ |
Fixes: #7098
This PR changes our docs theme to pydata theme: https://github.com/pydata/pydata-sphinx-theme, rest of the additional changes include:
sphinx_rtd_theme
usages withpydata-sphinx-theme
.copybutton
being used in code samples,pydata-sphinx-theme
has this support inbuilt.pydata-sphinx-theme
.markdown
in docs. - We no longer use markdown in docs.Class
declarations rather than in their__init__
methods, to make the docstrings be uniform forautoclass_content
to work correctly."https://docs.rapids.ai/assets/css/custom.css"
cudf.core.series.Series.factorize
withcudf.Series.factorize
.StringIndex
possible, previously we cannot docudf.StringIndex
, this PR enables it.pivot
&unstack
:cudf.pivot
&cudf.unstack
.For reviewing purposes, a demo live url to docs is here: https://6111734dedccb71ae0db66dc--docs-rapids-ai.netlify.app/api/cudf/stable/