Handle sliced structs properly in pack/contiguous_split. #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a null count based on the wrong range of validity bits.
nvdbaranec
added
bug
…ce. Added some more tests.
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8739 +/- ##
===============================================
Coverage ? 10.53%
===============================================
Files ? 116
Lines ? 18916
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16923
Partials ? 0 Continue to review full report at Codecov.
|
…egmented_count_set_bits() to take iterators for range indices.
ttnghia
requested changes
Jul 15, 2021
ttnghia
approved these changes
Jul 15, 2021
Comment on lines
156
to
164
| * @param[in] bitmask The bitmask whose non-zero bits outside the range in the | ||
| * boundary words will be counted. | ||
| * @param[in] num_ranges The number of ranges | ||
| * @param[in] first_bit_indices The indices (inclusive) of the first bit in each | ||
| * range | ||
| * @param[in] last_bit_indices The indices (exclusive) of the last bit in each | ||
| * range | ||
| * @param[in,out] null_counts The number of non-zero bits in each range to be | ||
| * updated |
There was a problem hiding this comment.
Sorry that I'm a bit OCD about the style. This is just a suggestion (align multiple-line param doxygen with the parameter name), you can ignore it if you don't like 😃
Suggested change
| * @param[in] bitmask The bitmask whose non-zero bits outside the range in the | |
| * boundary words will be counted. | |
| * @param[in] num_ranges The number of ranges | |
| * @param[in] first_bit_indices The indices (inclusive) of the first bit in each | |
| * range | |
| * @param[in] last_bit_indices The indices (exclusive) of the last bit in each | |
| * range | |
| * @param[in,out] null_counts The number of non-zero bits in each range to be | |
| * updated | |
| * @param[in] bitmask The bitmask whose non-zero bits outside the range in the | |
| * boundary words will be counted. | |
| * @param[in] num_ranges The number of ranges | |
| * @param[in] first_bit_indices The indices (inclusive) of the first bit in each | |
| * range | |
| * @param[in] last_bit_indices The indices (exclusive) of the last bit in each | |
| * range | |
| * @param[in,out] null_counts The number of non-zero bits in each range to be | |
| * updated |
| /** | ||
| * @brief Functor that returns the number of set bits for a specified word | ||
| * of a bitmask array. | ||
| * |
| * or exclusive. | ||
| * @param[in] d_bit_indices Pointer to an array of bit indices | ||
| */ | ||
| __host__ to_word_index(bool inclusive, size_type const* d_bit_indices) |
There was a problem hiding this comment.
I'm not sure if we ever need the __host__ qualifier here.
robertmaynard
approved these changes
Jul 15, 2021
vuule
approved these changes
Jul 19, 2021
|
Temporarily adding do-not-merge tag so @charlesbluca can run some additional tests. |
ttnghia
approved these changes
Jul 19, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-sliced struct columns (those with a positive offset) were not being handled correctly.
Dependent PR has been merged.