Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement __setitem__ for StructColumn #8737

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Implement __setitem__ for StructColumn #8737

merged 2 commits into from
Jul 15, 2021

Conversation

shaneding
Copy link
Contributor

Closes #8558

@shaneding shaneding requested a review from a team as a code owner July 13, 2021 21:57
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 13, 2021
@shaneding shaneding added non-breaking Non-breaking change feature request New feature or request labels Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@3ed87f3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4b2f7ff differs from pull request most recent head d1d3580. Consider uploading reports for the commit d1d3580 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8737   +/-   ##
===============================================
  Coverage                ?   10.65%           
===============================================
  Files                   ?      109           
  Lines                   ?    18307           
  Branches                ?        0           
===============================================
  Hits                    ?     1951           
  Misses                  ?    16356           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed87f3...d1d3580. Read the comment docs.

shwina
shwina approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaneding shaneding added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 15, 2021
@shwina
Copy link
Contributor

shwina commented Jul 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 73f2c44 into rapidsai:branch-21.08 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@shwina shwina shwina approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] StructColumn __setitem__ and __getitem__
3 participants
@shaneding @shwina @brandon-b-miller